-
Notifications
You must be signed in to change notification settings - Fork 421
feat(data-classes): fix SES date
field typing and add missing fields
#1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Change: - Add missing fields from SESMailCommonHeaders - Fix date type to be a str - Add missing docs for SESReceiptStatus status field - Add missing topicArn - Add missing fields for Bounce, S3 and WorkMail actions close aws-powertools#1025
@michaelbrewer @ran-isenberg I'm missing more information here - could you help me understand whether this is related to SES->Lambda, or a trigger to SES that then invokes Lambda with a slightly different invoke? I appreciate the links but I'm trying to understand how you ran into this in the first place, so we can prioritize it accordingly. We had a similar case with SNS->Lambda vs SNS->SQS->Lambda, so trying to figure out if this is a similar type of issue that we're proactively addressing vs an actual SES->Lambda that we didn't foresee previously. Thanks a lot! |
@heitorlessa i guess my confusion is as to why this was also added to the official GoLang AWS lambda events library. Are these actual payloads coming to AWS lambda |
@heitorlessa - i can split up the PR into the hotfix (typing), from the missing fields. |
Changes: - Fix date type to be a str and not List[str] - Add missing fields from SESMailCommonHeaders (bcc, cc, sender and replyTo) - Add missing dkimVerdict field - Add missing dmarcPolicy field - Add missing topicArn field - Add missing docs for SESReceiptStatus status field related aws-powertools#1025
I created a new PR with simplifies the fix to only what we need for our Lambda use cases. |
date
field typing and add missing fields
Changes: - Fix date type to be a str and not List[str] - Add missing fields from SESMailCommonHeaders (bcc, cc, sender and replyTo) - Add missing dkimVerdict field - Add missing dmarcPolicy field - Add missing topicArn field - Add missing docs for SESReceiptStatus status field related #1025
@sthulb can you clarify what this is being closed? It is a runtime error. |
Ok I see that the related PR was merged. Thanks. |
Yeah, figured it was polite to close the issue when it was resolved 😀 |
Haha. I just assumed the issue was rejected. |
Someone I give a little too. |
This is now released under 1.25.10 version! |
What were you trying to accomplish?
Use SESEvent with S3
Expected Behavior
date
field is set to aList[str]
and not astr
Current Behavior
Missing fields needs to be accessed via keys directly
Possible Solution
Add missing fields to SESEvent data class
Steps to Reproduce (for bugs)
Parsing regular SES message:
Parse a test SES S3 event
Environment
The text was updated successfully, but these errors were encountered: