Skip to content
This repository was archived by the owner on Apr 5, 2025. It is now read-only.

Include newly released Idempotency, Parameters, and Batch Processing utilities #71

Closed
wants to merge 1 commit into from

Conversation

p-mercury
Copy link
Contributor

No description provided.

@am29d
Copy link
Contributor

am29d commented Oct 2, 2023

Hey @p-mercury

thanks for open a PR!

We have resolved this issue in the typescript repo recently. In a nutshell, we need to also add the clients to the layer, otherwise there are cases where the library in the layer can't access the esbuild bundled sdk clients. It is especially challenging for developers to troubleshoot. I'd also have to work on additional optimisation for layer size. While it does work on node18 runtime provided sdk v3, it breaks for node16.

Can you include these optimisations as well?

Closes: #72

@am29d am29d self-requested a review October 2, 2023 15:20
@p-mercury
Copy link
Contributor Author

I'll have a look this weekend!

@github-actions
Copy link

This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Oct 20, 2023
@github-actions
Copy link

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

@github-actions github-actions bot closed this Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants