Skip to content

fix: #758 #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

fix: #758 #759

merged 1 commit into from
Feb 18, 2022

Conversation

jeromevdl
Copy link
Contributor

@jeromevdl jeromevdl commented Feb 17, 2022

Issue #, if available: #758

Description of changes:

remove trailing slash (if any) for multiple params

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

remove trailing slash for multiple params
Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pankajagrawal16 pankajagrawal16 changed the title fix #758 fix: #758 Feb 18, 2022
@pankajagrawal16 pankajagrawal16 merged commit 8370375 into aws-powertools:master Feb 18, 2022
jeromevdl added a commit to jeromevdl/aws-lambda-powertools-java that referenced this pull request Feb 18, 2022
remove trailing slash for multiple params
pankajagrawal16 added a commit that referenced this pull request Mar 1, 2022
* use serialization lib instead of internal stuff

* add ActiveMq & RabbitMQ

* feature: easy deserialization of event content

* rename methods in deserializer

* Update powertools-serialization/src/test/java/software/amazon/lambda/powertools/utilities/EventDeserializerTest.java

Co-authored-by: Pankaj Agrawal <[email protected]>

* chore: remove SQS and Idempotency examples (#754)

* build(deps): bump maven-jar-plugin from 3.2.0 to 3.2.2 (#756)

Bumps [maven-jar-plugin](https://github.com/apache/maven-jar-plugin) from 3.2.0 to 3.2.2.
- [Release notes](https://github.com/apache/maven-jar-plugin/releases)
- [Commits](apache/maven-jar-plugin@maven-jar-plugin-3.2.0...maven-jar-plugin-3.2.2)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-jar-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump aws.sdk.version from 2.17.130 to 2.17.131 (#755)

Bumps `aws.sdk.version` from 2.17.130 to 2.17.131.

Updates `software.amazon.awssdk:bom` from 2.17.130 to 2.17.131
- [Release notes](https://github.com/aws/aws-sdk-java-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-java-v2/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-java-v2@2.17.130...2.17.131)

Updates `http-client-spi` from 2.17.130 to 2.17.131
- [Release notes](https://github.com/aws/aws-sdk-java-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-java-v2/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-java-v2@2.17.130...2.17.131)

Updates `url-connection-client` from 2.17.130 to 2.17.131

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: software.amazon.awssdk:http-client-spi
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: software.amazon.awssdk:url-connection-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix #758 (#759)

remove trailing slash for multiple params

* changes post review:
- javadoc
- indentation
- better edge cases handling

* add tests for edge cases

* exception messages detailed

* deserialize a string as list

* documentation

* gradle example

Co-authored-by: Pankaj Agrawal <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jeromevdl jeromevdl deleted the fix758 branch November 4, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants