Skip to content

Update docs to use official plugin and externalize workaround as issue #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Update docs to use official plugin and externalize workaround as issue #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ And configure the aspectj-maven-plugin to compile-time weave (CTW) the aws-lambd
<plugins>
...
<plugin>
<groupId>com.nickwongdev</groupId>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<version>1.12.1</version>
<version>1.11</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
Expand Down Expand Up @@ -65,6 +65,7 @@ And configure the aspectj-maven-plugin to compile-time weave (CTW) the aws-lambd
</plugins>
</build>
```
**Note:** If you are working with Lambda on runtime post java8, please refer [issue](https://github.com/awslabs/aws-lambda-powertools-java/issues/50) for workaround

### Logging Configuration
Powertools extends the functionality of Log4J. Below is an example `log4j2.xml` file, with the `LambdaJsonLayout` configured.
Expand Down
5 changes: 3 additions & 2 deletions docs/content/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ And configure the aspectj-maven-plugin to compile-time weave (CTW) the aws-lambd
<plugins>
...
<plugin>
<groupId>com.nickwongdev</groupId>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<version>1.12.1</version>
<version>1.11</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
Expand Down Expand Up @@ -64,6 +64,7 @@ And configure the aspectj-maven-plugin to compile-time weave (CTW) the aws-lambd
</plugins>
</build>
```
**Note:** If you are working with lambda on runtime post java8, please refer [issue](https://github.com/awslabs/aws-lambda-powertools-java/issues/50) for workaround

## Tenets

Expand Down
5 changes: 2 additions & 3 deletions example/HelloWorldFunction/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,10 @@

<build>
<plugins>
<!-- We can use official one after https://github.com/mojohaus/aspectj-maven-plugin/pull/45 -->
<plugin>
<groupId>com.nickwongdev</groupId>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<version>1.12.1</version>
<version>1.11</version>
<configuration>
<source>${maven.compiler.source}</source>
<target>${maven.compiler.target}</target>
Expand Down