docs: Initial javadocs for PowerLogger class. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param key The name of the key to be logged | ||
| * @param value The value to be logged | ||
| */ | ||
| public static void customKey(String key, String value) { |
There was a problem hiding this comment.
Possibly rename the method as well at the same time then ? appendKey() ?
There was a problem hiding this comment.
We probably need an update here as well now :D https://github.com/awslabs/aws-lambda-powertools-java/blame/master/docs/content/core/logger.mdx#L138
msailes
force-pushed
the
initial-javadocs
branch
from
37bcc97 to
8b31def
Compare
msailes
force-pushed
the
initial-javadocs
branch
from
f8c7a9b to
e427fed
Compare
pankajagrawal16
approved these changes
Aug 19, 2020
stevehouel
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.