Full stack regression for structured logging #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajagrawal16
commented
Aug 18, 2020
| @@ -1,9 +1,9 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Configuration packages="com.amazonaws.services.lambda.runtime.log4j2"> | |||
| <Appenders> | |||
| <Console name="JsonAppender" target="SYSTEM_OUT"> | |||
| <File name="JsonAppender" fileName="target/logfile.json"> | |||
There was a problem hiding this comment.
This change make log4j to log to a file which we have used in our regression test to make sure the structured logging works correctly with correct lambda keys injected
There was a problem hiding this comment.
But, it is not the default appender? Why not creating two log4j config file to test both?
There was a problem hiding this comment.
It's so difficult to test system out. I think this is a very slick way of testing the functionality.
6 tasks
msailes
reviewed
Aug 19, 2020
| initMocks(this); | ||
| setupContext(); | ||
| //Make sure file is cleaned up before running full stack logging regression | ||
| FileChannel.open(Paths.get("target/logfile.json"), StandardOpenOption.WRITE).truncate(0).close(); |
msailes
reviewed
Aug 19, 2020
|
|
||
| assertThat(Files.lines(Paths.get("target/logfile.json"))) | ||
| .hasSize(1) | ||
| .allSatisfy(line -> assertThat(parseToMap(line)) |
msailes
approved these changes
Aug 19, 2020
stevehouel
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
This test if the logs printed via log4j config xml is structured as well has correct keys injected from lambda context