feat: single metric utility method to pick default namespace #305
Conversation
| * @param unit the unit type of the metric | ||
| * @param logger the MetricsLogger | ||
| */ | ||
| public static void withSingleMetricOnDefaultNameSpace(final String name, |
There was a problem hiding this comment.
This is great. Really appreciate that.
I'd say that maybe we can expand this to also set the AwsRequestId property. Probably we should do the same for withSingleMetric.
If we do the AwsRequestId part that will ensure that all metrics metrcisLogger() and withSingleMetric methods from MetricsUtils have the request Id and the traceId which ensures good observability and tracing
I know you've taken a very explicit approach in naming the function, but I think the OnDefaultNameSpace suffix can be dropped in favour of documentation calling out the usage of the default namespace.
There was a problem hiding this comment.
I kind of like the idea here. Appreciate the feedback.
There was a problem hiding this comment.
Suggestion incorporated. Now it will capture request id, trace id whenever possible as property
pankajagrawal16
force-pushed
the
feat-metric-utility-method
branch
from
7451546 to
10d7ff8
Compare
...rc/test/java/software/amazon/lambda/powertools/metrics/internal/LambdaMetricsAspectTest.java
Show resolved
Hide resolved
| @@ -16,6 +18,10 @@ public Object handleRequest(Object input, Context context) { | |||
| MetricsLogger metricsLogger = metricsLogger(); | |||
| metricsLogger.putMetric("Metric1", 1, Unit.BYTES); | |||
|
|
|||
|
|
|||
| withSingleMetric("Metric2", 1, Unit.COUNT, | |||
pankajagrawal16
force-pushed
the
feat-metric-utility-method
branch
from
f8c0dc1 to
b02cc6d
Compare
**Issue #297
Description of changes:
Expose another helper utility method to pick default namespace from top level annotation or env var
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.