Skip to content

fix(example): Update the example to v1.2.0 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

michaelbrewer
Copy link
Contributor

Description of changes:

Also include some code clean up in general and try to get the gradle project to build

Checklist

Also include some code clean up in general and try to get the gradle project to build
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @michaelbrewer

Even though this example project exists within the repo, we also have https://github.com/aws-samples/cookiecutter-aws-sam-powertools-java which we keep upto date with version updates and features.

But its good to have this example project upto date as well until we have it in the same repo.

@pankajagrawal16 pankajagrawal16 merged commit d2dbf10 into aws-powertools:master Feb 22, 2021
@michaelbrewer michaelbrewer deleted the fix-emaple-sync-up branch February 22, 2021 15:52
@michaelbrewer
Copy link
Contributor Author

@pankajagrawal16 thanks i will have a look at https://github.com/aws-samples/cookiecutter-aws-sam-powertools-java

I did run into alot of issues getting things to build or run in Intellij and the Gradle part does not work specifically. I will see if the cookiecutter has the same issues.

This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants