Skip to content

docs: Implement Logger and Tracer part #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2020
Merged

docs: Implement Logger and Tracer part #27

merged 6 commits into from
Aug 19, 2020

Conversation

stevehouel
Copy link
Contributor

Issue #, if available:

Description of changes:

Implement 2 new docs pages:

  • Logger
  • Tracer

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PowerToolsLogging(logEvent = true)
public APIGatewayProxyResponseEvent handleRequest(final APIGatewayProxyRequestEvent input, final Context context) {
...
PowerLogger.customKey("test", "willBeLogged");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably rename this api based on suggestion from heitor to make it explicit that it will append to the log. Just a note

Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pankajagrawal16
Copy link
Contributor

Probably need to rebase with master :p

@stevehouel stevehouel merged commit ea09bfc into master Aug 19, 2020
@stevehouel stevehouel deleted the automation branch August 19, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants