Tracer tests #21
Tracer tests #21
Conversation
pankajagrawal16
force-pushed
the
tracer-tests
branch
from
710acb6 to
0987a76
Compare
| withEntitySubsegment(SERVICE_NAME, name, entity, subsegment); | ||
| } | ||
|
|
||
| public static void withEntitySubsegment(String namespace, String name, Entity entity, Consumer<Subsegment> subsegment) { |
There was a problem hiding this comment.
Just some overloaded method for letting users to pass namespace as well if needed, else it will pic the default from service name
| @@ -58,15 +58,6 @@ public Object around(ProceedingJoinPoint pjp, | |||
| } | |||
| } | |||
|
|
|||
| private Object response(ProceedingJoinPoint pjp, Object methodReturn) { | |||
There was a problem hiding this comment.
Removed this for now unless we really need to.
pankajagrawal16
force-pushed
the
tracer-tests
branch
from
0987a76 to
bad87a6
Compare
pankajagrawal16
force-pushed
the
tracer-tests
branch
from
bad87a6 to
733edbf
Compare
|
Could you just add a bit of documentation just to explain for what purpose this class has been designed. I did not ask for a fully documented javadoc things, but just one sentence. Otherwise good job, it's good to start for that quality of test. |
I can take that as a separate PR to quickly document the intent of each of such classes. |
Ok perfect. |
Issue #, if available:
Description of changes:
Test coverage for Tracer functionality.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.