-
Notifications
You must be signed in to change notification settings - Fork 90
feat(idempotency): Add response hook feature #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tencyHandler. Update idempotency example with an example use-case modifying API GW headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @phipag! overall it looks good for me. I just left 2 comments.
Also, please consider adding the workflows we have in TS, PY and dotnet: https://docs.powertools.aws.dev/lambda/python/latest/utilities/idempotency/#idempotency-request-flow
examples/powertools-examples-idempotency/src/main/java/helloworld/App.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Make sure to address Leandro's questions.
…rld/App.java Co-authored-by: Leandro Damascena <[email protected]>
|
@leandrodamascena We have some diagrams already (see rendered preview docs: https://docs.powertools.aws.dev/lambda/java/preview/utilities/idempotency/#idempotency-request-flow). I like more how they are arranged for example in the Python docs. All bundled in one section. Whereas they are distributed across the page in the Java docs. I have in mind to review the docs anyway and will create another issue to track such updates. |
@leandrodamascena This is the tracker issue for the docs and I mapped individual sub-issues below this tracker -> #1352 |
Issue #, if available: #1780
Description of changes:
This PR adds the possibility of creating a response hook in the Idempotency configuration that will be applied on all idempotent responses before returning.
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.