feat(build): remove java 8 support in v2 #1589
Conversation
|
|
@jeromevdl , we'll need the changes in |
| @@ -13,7 +13,7 @@ jobs: | |||
| uses: actions/setup-java@5ffc13f4174014e2d4d4572b3d74c3fa61aeb2c2 # v3.11.0 | |||
| with: | |||
| distribution: 'corretto' | |||
| java-version: 8 | |||
| java-version: 11 | |||
There was a problem hiding this comment.
You're changing this so that when we eventually merge v2 into main, we change the publish JVM, right? Said otherwise - we don't want to merge this change into main too until then (unlike pr_build.yaml).
There was a problem hiding this comment.
If this is the case, do we also need to change pr_build etc as well, so that when we merge v2 into main , it ends up setup correctly?
| @@ -6,7 +6,6 @@ on: | |||
| push: | |||
There was a problem hiding this comment.
This one needs to be merged into main too
| @@ -1,15 +1,13 @@ | |||
| name: Build | |||
There was a problem hiding this comment.
This needs to be merged into main
| branches: | ||
| - v2 | ||
| paths: | ||
| - 'powertools-e2e-tests/**' |
There was a problem hiding this comment.
How come you've removed all the paths here on PR?
|
replaced by #1606 |
Issue #, if available: #1523
Description of changes:
Remove java 8 builds for pr and e2e tests github actions in v2.
Checklist
Breaking change checklist
not yet a breaking change (just the github actions)
RFC issue #: #1523
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.