chore: Support spotbugs running anywhere #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💾 Artifacts Size Report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1537 +/- ##
=====================================
Coverage ? 87.21%
Complexity ? 530
=====================================
Files ? 61
Lines ? 1854
Branches ? 230
=====================================
Hits ? 1617
Misses ? 163
Partials ? 74 ☔ View full report in Codecov by Sentry. |
|
|
If I understand correctly, it's not only spotbugs but also checkstyle, licence-header is for checkstyle, spotbugs-exclude for spotbugs |
jeromevdl
approved these changes
Dec 14, 2023
|
@jeromevdl exactly, it covers all of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Because spotbugs relies on a relative path to find its configuration and license-header, you can't run
mvn installfrom arbitrary subdirectories in the project successfully. For instance -powertools-parameters-mvn installwill fail here with an inability to find thelicense-headerfile. Thismaven.multiModuleProjectDirectoryvariable only gets set to the actual project root if a .mvn directory exists.By doing this we can easily use it to find files relative to the root without having to specify some relative path property in every single POM.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.