Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: HelloWorldStreamFunction in examples fails with sam #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: HelloWorldStreamFunction in examples fails with sam #1532
Changes from 66 commits
e66095e
ea0b496
615a095
5199105
37020f3
6386358
19679da
17c3a5e
1312c02
18c7f48
d968f3c
5ce71f7
35fbbac
6ffa295
d277c5c
6c4646e
6eecb90
66a3dc2
1431899
3396766
baa0e3f
16380a8
3f3f4e8
9d70b57
bcff275
84935c9
bf6da0d
f67f59a
f7288d5
f03b01b
e523554
a71e263
51fc239
6cef711
2444ba4
c24ee6d
de19b56
6e23b26
480dd8b
7a8dc16
de08cbc
bf843a7
9a154dd
e3c1cda
e8ddb45
ec17480
7d11fac
e932d10
ab31b09
d4bed89
4322ce9
494d73f
e6e2eb0
7c51a38
f814d4d
9a3a788
7fc6ff2
6635b50
9d8b614
223d196
eeaec59
150b28f
2411a07
772b30e
c69e3dc
2259c66
080edc0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful to add some info here about why you would use
RequestStreamHandler
- e.g. to make it clear that it has nothing to do with HTTP streaming.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note added to explain why RequestStreamHandler is preferred here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not quite right - I think the use case is more typically "we need to control [de]serialization ourselves".
I find "rather than a simple HTTP request-response model" a little confusing, because you still have exactly the same surrounding HTTP interaction as you would with a 'normal' RequestHandler, you're just choosing to read-and-write the
Body
using java streams rather than letting Lambda handle the serialization for you.@jeromevdl I don't know if you have some super clear wording handy? The core Lambda documentation isn't that prescriptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree wording is not clear or even wrong.
RequestStreamHandler
is not linked to Lambda streaming which was announced recently. It is used when you want to use your own serialization: https://docs.aws.amazon.com/lambda/latest/dg/java-handler.html#java-handler-interfaces. I agree the name of the interface is not super well chosen but it has nothing to do with streams...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to rephrase the wording to better reflect what this handler actually does