Skip to content

fix: Fix schema validation unit test build issues #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

scottgerring
Copy link
Contributor

Issue #, if available:
#1455

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4d3484f) 78.57% compared to head (79904a6) 78.57%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1456   +/-   ##
=========================================
  Coverage     78.57%   78.57%           
  Complexity      650      650           
=========================================
  Files            74       74           
  Lines          2506     2506           
  Branches        259      259           
=========================================
  Hits           1969     1969           
  Misses          455      455           
  Partials         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring changed the title Fix: Fix schema validation unit test build issues fix: Fix schema validation unit test build issues Oct 5, 2023
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Oct 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring marked this pull request as ready for review October 5, 2023 14:27
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

berk but OK

@scottgerring scottgerring merged commit 1140fcf into main Oct 5, 2023
@scottgerring scottgerring deleted the fix-build branch October 5, 2023 15:54
jeromevdl pushed a commit that referenced this pull request Oct 12, 2023
* Is it just the one test?

* What about this

* Temporary fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants