-
Notifications
You must be signed in to change notification settings - Fork 90
docs: Adding Kotlin example. #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jasoniharris thanks for the contribution!
Apropos build - I think something funny is going on in actions. I will re-run tomorrow and see if it self-resolves, else we can dive deeper. Doesn't seem to be related to your change.
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
Deploying with SAM:
I end up with:
and a stacktrace in the logs:
Have I missed something? |
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
I think we need to update the instructions. The correct way with SAM should be |
… Kotlin examples.
…tests too and is more idiomatic and readme to be more descriptive
examples/powertools-examples-core/kotlin/gradle/build.gradle.kts
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/gradle/build.gradle.kts
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/kotlin/gradle/src/main/kotlin/helloworld/App.kt
Outdated
Show resolved
Hide resolved
… Kotlin examples.
…tests too and is more idiomatic and readme to be more descriptive
# Conflicts: # examples/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for me. The E2E tests fail because of the security config, not an issue with the PR. @jeromevdl do you want to have a skim before we merge to make sure i've not missed anything funny given recent repo structure issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor things and we're good
pom.xml
Outdated
@@ -55,7 +55,7 @@ | |||
<module>powertools-large-messages</module> | |||
<module>powertools-e2e-tests</module> | |||
<module>powertools-batch</module> | |||
<module>examples</module> | |||
<!-- <module>examples</module>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed
<!-- <module>examples</module>--> |
Kudos, SonarCloud Quality Gate passed! |
Thanks @jasoniharris and @AlexeySoshin ! |
Issue #, if available:
Description of changes:
Adding an example for Kotlin with Gradle- [email protected]
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.