Skip to content

fix: add aspectj-rt to batch e2e #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix: add aspectj-rt to batch e2e #1410

merged 2 commits into from
Sep 1, 2023

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available:

Description of changes:

fix end-to-end tests in v2, missing aspectjrt on batch e2e

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2@2d3e865). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1410   +/-   ##
=====================================
  Coverage      ?   77.17%           
  Complexity    ?      522           
=====================================
  Files         ?       64           
  Lines         ?     2134           
  Branches      ?      223           
=====================================
  Hits          ?     1647           
  Misses        ?      415           
  Partials      ?       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

@jeromevdl jeromevdl merged commit 8586bf6 into v2 Sep 1, 2023
@jeromevdl jeromevdl deleted the fix/e2e-tests-batch branch September 1, 2023 08:00
jeromevdl added a commit that referenced this pull request Oct 12, 2023
* add aspectj-rt
* run e2e on v2 updates
jeromevdl added a commit that referenced this pull request Oct 13, 2023
* add aspectj-rt
* run e2e on v2 updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants