-
Notifications
You must be signed in to change notification settings - Fork 90
chore: [V2] rename 'core' module to 'common' #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ls-common/src/main/java/software/amazon/lambda/powertools/core/internal/LambdaConstants.java
Outdated
Show resolved
Hide resolved
We still have Now it is a little less wrong - it is the concept of "core utilities", which are split over What should we call the example? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## v2 #1364 +/- ##
=====================================
Coverage ? 77.20%
Complexity ? 522
=====================================
Files ? 64
Lines ? 2136
Branches ? 223
=====================================
Hits ? 1649
Misses ? 415
Partials ? 72 ☔ View full report in Codecov by Sentry. |
Fixed namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Kudos, SonarCloud Quality Gate passed!
|
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
* First rename * POM updates * Rename namespace * Fix * Fix? * More namespace changes * Rename core examples to core utilities * Finish renaming core utilities * Clean up name/description of module * More change * Fix readme
Issue #, if available:
#1076
Description of changes:
The Java 'core' module has nothing to do with the powertools concept of 'core' utilities - logging, tracing, metrics - but is rather common functionality shared by the other PT modules.
To clarify this distinction, we will rename this to 'powertools-common', which fits with the other PT libraries naming scheme.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.