Skip to content

chore: [V2] rename 'core' module to 'common' #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 24, 2023
Merged

chore: [V2] rename 'core' module to 'common' #1364

merged 12 commits into from
Aug 24, 2023

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Aug 15, 2023

Issue #, if available:
#1076

Description of changes:

The Java 'core' module has nothing to do with the powertools concept of 'core' utilities - logging, tracing, metrics - but is rather common functionality shared by the other PT modules.

To clarify this distinction, we will rename this to 'powertools-common', which fits with the other PT libraries naming scheme.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring scottgerring marked this pull request as ready for review August 15, 2023 10:23
@scottgerring
Copy link
Contributor Author

We still have examples/powertools-examples-core . Previously this was super wrong - it had nothing to do with the 'core' module.

Now it is a little less wrong - it is the concept of "core utilities", which are split over powertools-logging, powertools-tracing, powertools-metrics.

What should we call the example?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 15, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2@69eafe6). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1364   +/-   ##
=====================================
  Coverage      ?   77.20%           
  Complexity    ?      522           
=====================================
  Files         ?       64           
  Lines         ?     2136           
  Branches      ?      223           
=====================================
  Hits          ?     1649           
  Misses        ?      415           
  Partials      ?       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring requested a review from jeromevdl August 15, 2023 14:29
@scottgerring
Copy link
Contributor Author

Fixed namespace

@scottgerring scottgerring self-assigned this Aug 17, 2023
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@scottgerring scottgerring linked an issue Aug 24, 2023 that may be closed by this pull request
2 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring merged commit 50e7b56 into v2 Aug 24, 2023
@scottgerring scottgerring deleted the v2-rename-core branch August 24, 2023 13:26
jeromevdl pushed a commit that referenced this pull request Aug 30, 2023
* First rename

* POM updates

* Rename namespace

* Fix

* Fix?

* More namespace changes

* Rename core examples to core utilities

* Finish renaming core utilities

* Clean up name/description of module

* More change

* Fix readme
jeromevdl pushed a commit that referenced this pull request Oct 12, 2023
* First rename

* POM updates

* Rename namespace

* Fix

* Fix?

* More namespace changes

* Rename core examples to core utilities

* Finish renaming core utilities

* Clean up name/description of module

* More change

* Fix readme
jeromevdl pushed a commit that referenced this pull request Oct 12, 2023
* First rename

* POM updates

* Rename namespace

* Fix

* Fix?

* More namespace changes

* Rename core examples to core utilities

* Finish renaming core utilities

* Clean up name/description of module

* More change

* Fix readme
jeromevdl pushed a commit that referenced this pull request Oct 13, 2023
* First rename

* POM updates

* Rename namespace

* Fix

* Fix?

* More namespace changes

* Rename core examples to core utilities

* Finish renaming core utilities

* Clean up name/description of module

* More change

* Fix readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: v2 - rename 'core' module
3 participants