-
Notifications
You must be signed in to change notification settings - Fork 90
docs: Update gradle configuration readme #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromevdl looking at the issue and your PR for the templates, I think this is all we need? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe give a try with a v8.0 of gradle not to force people to use the latest. Maybe mention to check their version with gradle -v
or to update the version in the property file somewhere if they use the local gradlew.
@jeromevdl i'll add a complete gradle example in |
This is a pain to try and debug, with the gradle wrapper and the caching of deps. Fortunately I found some wording on their website:
|
…fo' into fix-gradle-build-info
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
=========================================
Coverage 78.93% 78.93%
Complexity 652 652
=========================================
Files 74 74
Lines 2506 2506
Branches 259 259
=========================================
Hits 1978 1978
Misses 446 446
Partials 82 82 ☔ View full report in Codecov by Sentry. |
I've added a Gradle example, but for Java 8 only. It doesn't seem like there is an easy way to setup a JDK-independent gradle build like we have with maven, because the gradle wrapper itself needs to change depending on the JDK + aspect version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments...
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
…fo' into fix-gradle-build-info
Kudos, SonarCloud Quality Gate passed!
|
* Update gradle configuration readme * Move into configuration * Starting gradle example * Remove * Start again * Update documentation for gradle * Clarify gradle versions a bit better * Starting gradle example * Cleanup gradle example * Build gradle example * Fix build hopefully * Add gradle wrapper * Formatting * Update docs/index.md Co-authored-by: Jérôme Van Der Linden <[email protected]> * Apply suggestions from code review Co-authored-by: Jérôme Van Der Linden <[email protected]> * Updated README with sam instructions --------- Co-authored-by: Jérôme Van Der Linden <[email protected]>
Issue #, if available:
#1358 (Update gradle documentation)
#1067 (Improve example coverage)
Description of changes:
Updates README to provide up-to-date gradle build instructions for Java11+.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.