Support for custom keys in the logs #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajagrawal16
force-pushed
the
custom-key-support
branch
2 times, most recently
from
f8b6c8b to
5dcd9a9
Compare
msailes
reviewed
Jul 31, 2020
msailes
reviewed
Jul 31, 2020
msailes
reviewed
Jul 31, 2020
src/main/java/org/apache/logging/log4j/core/layout/LambdaJsonLayout.java
Show resolved
Hide resolved
pankajagrawal16
force-pushed
the
custom-key-support
branch
6 times, most recently
from
232f07d to
6f795de
Compare
msailes
reviewed
Jul 31, 2020
pankajagrawal16
force-pushed
the
custom-key-support
branch
from
6f795de to
10d4c6f
Compare
msailes
approved these changes
Aug 3, 2020
| @@ -14,7 +14,8 @@ | |||
| import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyResponseEvent; | |||
| import org.apache.logging.log4j.LogManager; | |||
| import org.apache.logging.log4j.Logger; | |||
| import software.aws.lambda.logging.PowerToolsLogging; | |||
| import software.aws.lambda.logging.client.PowerLogger; | |||
| import software.aws.lambda.logging.client.PowerToolsLogging; | |||
There was a problem hiding this comment.
Can you explain your thoughts behind the package move? I'm not sure what 'client' adds or means in this context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is suggestive implementation of supporting custom keys in structured log.
Other option is that when client calls the exposed API method, we maintain those custom keys ourselves. Which is ok as and is up for discussion.
Reason for putting it at annotation level is that it gives nice overview of all the custom keys but many be its just additional overhead.
This is Up for discussion.
PS: I will write tests after we finalize the approach