Skip to content

fix: examples shouldn't be deployed to mvn central #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

scottgerring
Copy link
Contributor

Issue #, if available:

Description of changes:

The last deploy to maven central successfully deployed, but failed the overall build when it got to the examples and tried and failed to deploy them. This disables deploy for each of them - examples don't belong in maven central.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring scottgerring marked this pull request as ready for review June 30, 2023 08:25
@scottgerring scottgerring requested a review from jeromevdl June 30, 2023 08:25
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (3a158fe) 70.87% compared to head (4816b62) 70.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1253   +/-   ##
=========================================
  Coverage     70.87%   70.87%           
  Complexity      541      541           
=========================================
  Files            72       72           
  Lines          2328     2328           
  Branches        254      254           
=========================================
  Hits           1650     1650           
  Misses          558      558           
  Partials        120      120           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

@jeromevdl jeromevdl merged commit cca3691 into main Jun 30, 2023
@jeromevdl jeromevdl deleted the fix-examples-deploy branch June 30, 2023 08:31
eldimi pushed a commit to eldimi/aws-lambda-powertools-java that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants