Skip to content

chore: Update docs base origin url #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 23, 2023

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jun 23, 2023

Issue #, if available: #1237

Description of changes:

Update base origin variable in mkdocs javascript
Change awslabs.github.io to docs.powertools.aws.dev

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl
Copy link
Contributor

There are other references, can I ask you to update all ? Otherwise I'll do a PR because I cannot get yours, it's not on this repo...

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (acf91bc) 70.87% compared to head (fa4c311) 70.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1238   +/-   ##
=========================================
  Coverage     70.87%   70.87%           
  Complexity      541      541           
=========================================
  Files            72       72           
  Lines          2328     2328           
  Branches        254      254           
=========================================
  Hits           1650     1650           
  Misses          558      558           
  Partials        120      120           
Impacted Files Coverage Δ
...ambda/powertools/parameters/AppConfigProvider.java 70.49% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hjgraca
Copy link
Contributor Author

hjgraca commented Jun 23, 2023

There are other references, can I ask you to update all ? Otherwise I'll do a PR because I cannot get yours, it's not on this repo...

I believe I updated all references from awslabs.github.io to docs.powertools.aws.dev and new url format

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeromevdl jeromevdl merged commit 7c09df4 into aws-powertools:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants