Skip to content

Support batches with > 10 messages #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VictorJuliani opened this issue Dec 20, 2021 · 7 comments
Closed

Support batches with > 10 messages #663

VictorJuliani opened this issue Dec 20, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@VictorJuliani
Copy link

Is your feature request related to a problem? Please describe.

Yes. For a while now, it's possible to receive batches with more than 10 entries in Lambda (ref). However, the calls from SendMessageBatch and DeleteMessageBatch in AWS PowerTools are made with the entire set of messages that are being sent to the DLQ or deleted from the SQS.

Those APIs, however, are limited to 10 entries each, which results in exceptions like TooManyEntriesInBatchRequestException: Maximum number of entries per request are 10. You have sent 226.

Describe the solution you'd like

Batch API calls should be made in chunks of 10 to satisfy the SDK restrictions.

Describe alternatives you've considered

So far, reducing the batch size to 10, which is not ideal for my solution due to the amount of concurrent lambdas.

@pankajagrawal16
Copy link
Contributor

Thanks for opening the issue. I believe we made a similar fix in python powertools as well. I will look into fixing it this week.

@pankajagrawal16 pankajagrawal16 self-assigned this Dec 21, 2021
@pankajagrawal16 pankajagrawal16 added the bug Something isn't working label Dec 21, 2021
@heitorlessa
Copy link
Contributor

heitorlessa commented Dec 21, 2021 via email

@pankajagrawal16
Copy link
Contributor

pankajagrawal16 commented Dec 21, 2021

Yeah. This one is for Java which does not have the new batch implementation yet, But this is a bug/limited functionality in older util

@heitorlessa
Copy link
Contributor

heitorlessa commented Dec 21, 2021 via email

@pankajagrawal16
Copy link
Contributor

Yeah, for the older one we still have to fix that too - we have a PR at an okay stage but we’re fixing it for the next release. We’ll add a warning for them to move To the new one as their cost and latency will decrease too

On Tue, 21 Dec 2021 at 16:16, Pankaj Agrawal @.> wrote: Yeah. This one is for Java which does not have the new batch implementation yet :p .. but this is a bug/limited functionality in older util — Reply to this email directly, view it on GitHub <#663 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZPQBFBFN6R5WLKV3YPHKLUSCK4RANCNFSM5KN6IYUQ . You are receiving this because you commented.Message ID: @.>

Ah ok.. so thats not merged yet in python as well. Good to know. I will look if I can get this fix out first and then plan for newer version post that.

@pankajagrawal16
Copy link
Contributor

Related python issue aws-powertools/powertools-lambda-python#824

@pankajagrawal16
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants