Skip to content

Library naming issue #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ErcinDedeoglu opened this issue Jun 12, 2019 · 3 comments
Open

Library naming issue #29

ErcinDedeoglu opened this issue Jun 12, 2019 · 3 comments

Comments

@ErcinDedeoglu
Copy link

module.exports = factory(require("AutoNumeric"));

exports["VueAutonumeric"] = factory(require("AutoNumeric"));

require("AutoNumeric") looking for wrong way. it should be renamed to require("autonumeric") (lowercase)
When I change it to lowercase it start working.

Any idea?

@truesteps
Copy link

It's a bug, please fix it :D

@AlexandreBonneau
Copy link
Member

The files in dist are auto-generated by Webpack.
On my end, vue-autonumeric works like a charm with that require.
I'll have to check if that require change does no break existing softwares.

@truesteps
Copy link

Yes, for me on MAC it works as a charm as well but as soon as I try to deploy it on any Linux machine (which is formatted to be Case sensitive), the build fails. The require in the component is fine but when webpack builds it, either browserify or babel imports its as AutoNumeric rather than autonumeric and case sensitive filesystems will always fail to locate it.

agentschmitt added a commit to SamhammerAG/vue-autoNumeric that referenced this issue Feb 5, 2020
a65162 added a commit to a65162/vue-autoNumeric that referenced this issue Jul 6, 2020
Fixes autoNumeric#29, autoNumeric#25 remove requirement of webpack alias for autonumeric de…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants