Skip to content

Updates to Content Guidelines #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 17, 2017
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 33 additions & 15 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,32 +17,50 @@ with the tutorial.

Content Guidelines
--------
Narrative:
- Please read through the other tutorials to get a sense of the desired tone and length.
- Use the first-person inclusive plural ("we"). For example, "We are going to make a plot which..", "Above, we did it the hard way, but here is the easier way..."
- Avoid words such as "obviously","just", "simply", "easily". For example, "we just have to do this one thing."
- Include brief explanations and descriptions

Content:
- Demo ~2-3 astro-relevant functions and 2-3 generic but commonly used functions (e.g., numpy, matplotlib)
Content Overview:
- Each tutorial should have 3-5 explicit [Learning Goals](http://tll.mit.edu/help/intended-learning-outcomes) and demonstrate ~2-3 astro-relevant functions and 2-3 generic but commonly used functions (e.g., numpy, matplotlib)
- Roughly follow this progression:
- Intput/Output: read in some data
- use [astroquery](https://astroquery.readthedocs.io/en/latest/) where possible
- Analysis: do something insightful/useful
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vague?

- Visualization: make a pretty figure
- Include relevant uses for these packages
- [astropy.units](http://docs.astropy.org/en/stable/units/)
- [astropy.coordinates](http://docs.astropy.org/en/stable/coordinates/)
- [astroquery](https://astroquery.readthedocs.io/en/latest/)

- use [astropy.visualization](http://docs.astropy.org/en/stable/visualization/) where possible

Code:
- Demonstrate good commenting practice
- add comments to bits of code which use concepts not included in Learning Goals
- Demonstrate best practices of variable names.
- Variables should be all lower case with words separated by underscores.
- Variable names should be descriptive. E.g., galaxy_mass, u_mag.
- Use the print function explicitly to display information about variables
- As much as possible, comply with [PEP8](https://www.python.org/dev/peps/pep-0008/)
- Imports
- Do not import `*`. Import package and functions explicitly.
- Recommended import block and abbreviations
```python
import numpy as np
import matplotlib as mpl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also import matplotlib.pyplot as plt

import astropy.units as u
import astropy.coordinates as coord
from astropy.io import fits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block could use a small title. Perhaps Suggested import abbreviations

%matplotlib inline # make plots display in notebooks
```


Narrative:
- Please read through the other tutorials to get a sense of the desired tone and length.
- Use [Markdown formatting](http://jupyter-notebook.readthedocs.io/en/latest/examples/Notebook/Working%20With%20Markdown%20Cells.html) in text cells for formatting, links, latex, and code snippets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Jupiter markdown formatting]

- Title should be short and descrictive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "descriptive"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"decrictive" -> "descriptive"

- List all author's full names (comma separated) and link to github profile and/or [ORCID](https://github.com/astropy/astropy-tutorials/pull/171) id.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to link to this PR for ORCID? also is "ORCID id" redundant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They call it an ORCID iD: https://orcid.org/register

- Include [Learning Goals](http://tll.mit.edu/help/intended-learning-outcomes) at the top as a bulleted list.
- Include Keywords as a comma separated list of topics, packages, and functions demonstrated.
- The first paragraph should give a brief overview of the entire tutorial including relevant astronomy concepts.
- Use the first-person inclusive plural ("we"). For example, "We are going to make a plot which..", "Above, we did it the hard way, but here is the easier way..."
- Section Headings should be in the imperative mood. For example, "Download the data."
- Avoid words such as "obviously","just", "simply", "easily". For example, "we just have to do this one thing."
- Use `<div class="alert alert-info">Note</div>` for Notes and `<div class="alert alert-warning">Warning</div>` for Warnings.

Description:
- Compile a list of the functions and packages the tutorial demonstartes and include a short a description with the pull request.

Procedure
---------
Expand Down