Skip to content

Update NoResolution.md #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2024
Merged

Update NoResolution.md #174

merged 2 commits into from
Jul 5, 2024

Conversation

phapdinh
Copy link
Contributor

there was a typo

@phapdinh
Update NoResolution.md
d251c4e 
there was a typo
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9320848

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

srenatus
srenatus reviewed Jul 5, 2024
View reviewed changes
docs/problems/NoResolution.md
@@ -15,7 +15,7 @@ This problem indicates that TypeScript can’t find any file with a supported fi

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ There's another one -- "Consequnces" -- would you mind including that? I was just about to open a PR myself, but since you're already on it 😎

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. thanks

andrewbranch
andrewbranch approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andrewbranch andrewbranch merged commit 0e991a4 into arethetypeswrong:main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srenatus srenatus srenatus left review comments

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phapdinh @srenatus @andrewbranch