Notify running LS about build complete. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: arduino/arduino-ide#714 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
arduino/arduino-ide#714
branch
from
404d8dd to
3dbfd72
Compare
fstasi
approved these changes
Jul 11, 2022
| } catch (e) { | ||
| console.log(e); | ||
| } catch (err) { | ||
| console.error('Failed to start the language server.', err); |
There was a problem hiding this comment.
Why did you prefer the console.error over the showError function?
There was a problem hiding this comment.
Good question; the original code does not show the error if the LS failed to start. I did not want to change this behavior, but I could do it.
Note, if we use vscode.window.showErrorMessage here, it will be a notification message in IDE2.
There was a problem hiding this comment.
The only effective change here is that I use console.error instead of console.log with an additional Failed to start the language server. message.
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New:
arduino.languageserver.notifyBuildDidCompletecommand that can be called from the IDE2 to set the new build path of the libraries after a verify,ino/didCompleteBuildprotocol extension. (See Some tweaks on how sketch is rebuild during editing arduino-language-server#118)Ref: arduino/arduino-ide#714
Signed-off-by: Akos Kitta [email protected]