Skip to content

Commit f186c2f

Browse files
authored
Remove unused job outputs from release workflow (#37)
In a previous revision of the release workflow, the updated checksums were determined by the macOS notarization job and then passed to the subsequent job via job outputs. That approach was changed during a later refactoring, but the code that declares the job outputs was not removed at that time. The checksum job output declaration code is now unused (and unusable since the checksum determination and output definitions were removed) so it only makes the workflows more difficult to understand and maintain. For this reason, the vestigial code is hereby removed from the workflow.
1 parent 9b5d503 commit f186c2f

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

.github/workflows/release-go-task.yml

-4
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ jobs:
7070
name: Notarize ${{ matrix.build.folder-suffix }}
7171
runs-on: macos-latest
7272
needs: create-release-artifacts
73-
outputs:
74-
checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }}
75-
checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }}
7673
permissions:
7774
contents: read
7875

@@ -161,7 +158,6 @@ jobs:
161158
gon "${{ env.GON_CONFIG_PATH }}"
162159
163160
- name: Re-package binary
164-
id: re-package
165161
working-directory: ${{ env.DIST_DIR }}
166162
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
167163
run: |

0 commit comments

Comments
 (0)