Skip to content

Commit 9b5d503

Browse files
authored
Move definition of package filename to dedicated step in release workflow (#36)
The package filename is referenced in multiple places in the release workflow. In order to avoid code duplication, it is defined once as an environment variable, then that variable referenced in each of the instances where the filename is needed. Previously, this was done by first defining and referencing a shell environment variable at the point of the first usage, then defining a workflow environment variable and referencing that in the second usage. The maintainability and readability of the workflow is improved by using a single workflow environment variable, defined in the step dedicated to defining such variables, then referencing it consistently in all usages.
1 parent 892eafa commit 9b5d503

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/release-go-task.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ jobs:
9292
run: |
9393
# See: https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable
9494
echo "BUILD_FOLDER=${{ env.PROJECT_NAME }}_osx_${{ matrix.build.folder-suffix }}" >> "$GITHUB_ENV"
95+
TAG="${GITHUB_REF/refs\/tags\//}"
96+
echo "PACKAGE_FILENAME=${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}" >> $GITHUB_ENV
9597
9698
- name: Checkout repository
9799
uses: actions/checkout@v4
@@ -166,10 +168,7 @@ jobs:
166168
# GitHub's upload/download-artifact actions don't preserve file permissions,
167169
# so we need to add execution permission back until the action is made to do this.
168170
chmod +x "${{ env.BUILD_FOLDER }}/${{ env.PROJECT_NAME }}"
169-
TAG="${GITHUB_REF/refs\/tags\//}"
170-
PACKAGE_FILENAME="${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}"
171-
tar -czvf "$PACKAGE_FILENAME" "${{ env.BUILD_FOLDER }}"
172-
echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
171+
tar -czvf "${{ env.PACKAGE_FILENAME }}" "${{ env.BUILD_FOLDER }}"
173172
174173
- name: Upload artifact
175174
uses: actions/upload-artifact@v3

0 commit comments

Comments
 (0)