Pluggable monitors #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
pluggable-monitor
branch
from
3cb0067 to
70ac9f9
Compare
per1234
previously requested changes
Jul 11, 2021
Co-authored-by: per1234 <[email protected]>
silvanocerza
reviewed
Aug 4, 2021
|
All in all it looks good to me but I think we must also define the states a monitor can be in, much like we did with the pluggable discoveries. Doing so will ease integration and development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First proposal for "Pluggable Monitors", this one together with the "Pluggable Discovery", completes the plugin framework to extend the Arduino ecosystem.
Close #4