Remove fork filter conditional from Go nightly build workflow #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conditional was intended to prevent the workflow from causing confusion and annoyance to contributors with no need or interest in publishing a nightly build as it failed daily in their forks due to the necessary secrets not having been defined. Since the time this was added to the workflow, GitHub Actions has been changed so that, even after enabling workflows globally, scheduled workflows are disabled in forks. The forker must manually enable each scheduled workflow. I think that the sort of contributor who is savvy enough to enable workflows is also savvy enough to understand from the workflow name that it does not apply to their fork and skip enabling it. Even if they did accidentally enable it, they will remember doing so when the workflow fails later that day.
per1234
added
type: enhancement
silvanocerza
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditional was intended to prevent the workflow from causing confusion and annoyance to contributors with no need
or interest in publishing a nightly build as it failed daily in their forks due to the necessary secrets not having been
defined.
Since the time this was added to the workflow, GitHub Actions has been changed so that, even after enabling workflows
globally, scheduled workflows are disabled in forks. The forker must manually enable each scheduled workflow. I think
that the sort of contributor who is savvy enough to enable workflows is also savvy enough to understand from the workflow
name that it does not apply to their fork and skip enabling it. Even if they did accidentally enable it, they will
remember doing so when the workflow fails later that day.