Strip newline from Go build task's LDFLAGS value #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior of the YAML folded block style is to have a final newline. Even though it seems to work fine as-is, since this variable defines a flag used in a command, it is more appropriate to not have a newline. This is achieved by adding the "strip chomping indicator".
per1234
added
type: enhancement
silvanocerza
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of the YAML folded block style is to have a final newline. Even though it seems to work fine as-is,
since this variable defines a flag used in a command, it is more appropriate to not have a newline. This is achieved by
adding the "strip chomping indicator".
This is the way it is configured in Arduino Lint, where it is working nicely:
https://github.com/arduino/arduino-lint/blob/5ef264939ff22a4a825df2e44acdd5033dd16e00/Taskfile.yml#L281