Skip to content

Fix Identify Prerelease step in the release worflow #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

MatteoPologruto
Copy link
Contributor

The condition to identify a prerelease was recently split to reduce the length of the line, causing the workflow to fail throwing this error:

/home/runner/work/_temp/1435c811-653a-480e-bcf6-c38ae8bd5d7e.sh: line 7: unexpected token `newline', conditional binary operator expected
Error: Process completed with exit code 2.

Adding some \ inside the condition should fix this issue.
This PR is also introducing an explicit comparison inside the test, which checks whether semver returns a string or not, to make the code more readable.

@MatteoPologruto MatteoPologruto added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Jan 31, 2023
@MatteoPologruto MatteoPologruto self-assigned this Jan 31, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matteo!

@per1234 per1234 added topic: code Related to content of the project itself and removed topic: infrastructure Related to project infrastructure labels Jan 31, 2023
@MatteoPologruto MatteoPologruto merged commit 2b2aabc into arduino:main Jan 31, 2023
@MatteoPologruto MatteoPologruto deleted the fix-prerelease-step branch January 31, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants