Update release workflows using parallelization #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
per1234
requested changes
Oct 13, 2022
...-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-nightly-task.yml
Outdated
Show resolved
Hide resolved
...-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-nightly-task.yml
Outdated
Show resolved
Hide resolved
...w-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-tester-task.yml
Outdated
Show resolved
Hide resolved
...w-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-tester-task.yml
Outdated
Show resolved
Hide resolved
...w-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-tester-task.yml
Outdated
Show resolved
Hide resolved
...w-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-tester-task.yml
Outdated
Show resolved
Hide resolved
...w-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-tester-task.yml
Outdated
Show resolved
Hide resolved
MatteoPologruto
force-pushed
the
parallel-dist
branch
3 times, most recently
from
d92b352 to
d1b4565
Compare
|
Thanks for the suggestions @per1234! Here is a workflow run in which I tested the changes made to |
per1234
approved these changes
Oct 13, 2022
Introducing the use of a matrix, greatly improves time performances during the build making process, since each build task is performed simultaneously. To support this, a check has been added to avoid creating the same changelog more than once. The calculation of the checksums has also been modified. Previously, it was done three (3) times at different stages of the workflow. This is pointless, since the only checksums that matter are the ones calculated when the files are in their final form. For this reason, it is now only done once during the release creation.
Introducing the use of a matrix, greatly improves time performances during the build making process, since each build task is performed simultaneously. The calculation of the checksums has also been modified. Previously, it was done three (3) times at different stages of the workflow. This is pointless, since the only checksums that matter are the ones calculated when the files are in their final form. For this reason, it is now only done once during the release creation.
Introducing the use of a matrix, greatly improves time performances during the build making process, since each build task is performed simultaneously. Furthermore, it allows to directly upload a different artifact for each build. To complete this set of changes, a separate job to calculate the checksums and upload the relative artifact has been added to the workflow.
MatteoPologruto
force-pushed
the
parallel-dist
branch
from
d1b4565 to
5c9debd
Compare
per1234
added
topic: code
umbynos
reviewed
Mar 17, 2023
| echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV | ||
| echo "::set-output name=checksum-${{ matrix.artifact.name }}::$CHECKSUM_LINE" |
There was a problem hiding this comment.
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
release-go-task,publish-go-nigthly-taskandpublish-go-tester-tasknow use a matrix to run build tasks simultaneously instead of running them sequencially withdist:all. This also allows to directly upload a different artifact for each build inpublish-go-tester-task.DistTasksno longer has adist:alltask.This changes were originally introduced with PR 1883 in the arduino-cli repository.