Align macOS filename with others in checksum file #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A file containing a list of checksums for the build archives is generated by the system used by the "Release Go" template. The macOS build archive is modified later in the process as a result of the repackaging following notarization. For this reason, the checksum file must be updated. The `sha256sum` command used to generate the original file separates the checksum from the filename with two spaces. Previously, the command that updates the macOS checksum only added a single space, which caused the formatting of the file to be inconsistent: ``` d5dccece4253b8c4c7e86b80f77433b3f3363ee89dcf11fd91d4638bbc66b61e bhy_0.0.1_Linux_32bit.tar.gz 15557602d6aa6fd0a64b88393b7bd06fde35d6855a51c6b6a56a89ebd7d55153 bhy_0.0.1_Linux_64bit.tar.gz d7564496bfbb471a79365a838ce6c8a2bc41285b1b687d58747308c78c831332 bhy_0.0.1_macOS_64bit.tar.gz ```
per1234
added
type: imperfection
umbynos
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A file containing a list of checksums for the build archives is generated by the system used by the "Release Go"
template. The macOS build archive is modified later in the process as a result of the repackaging following notarization.
For this reason, the checksum file must be updated. The
sha256sumcommand used to generate the original file separatesthe checksum from the filename with two spaces. Previously, the command that updates the macOS checksum only added a
single space, which caused the formatting of the file to be inconsistent: