-
-
Notifications
You must be signed in to change notification settings - Fork 10
Bump Node version to 20 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Node version to 20 #67
Conversation
+1 to prioritizing this PR |
I hope this can be merged, as GitHub has announced that it will stop supporting Node16 "by Spring 2024". https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ |
@per1234 from what I can tell it looks like you're the main maintainer of this project. Any chance this can be merged? |
Update versions in the project dependency manifesto
@latchdevel, please sign the CLA such that this PR can be merged. |
Hi @per1234, This pull request is ready for review and merging. Best regards. |
Looking for PR reviewers: @MatteoPologruto, @LArkema, @stefan-b-jakobsson, @per1234... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not entirely orthodox to review the changes myself, but there seems to be a lack of will, and the truth is that they are quite simple.
Looking for PR reviewers: @umbynos , @alessio-perugini , @cmaglie .... |
@latchdevel thank you for the ping. Sorry for the late response, I will prepare a followup PR to address some changes made in arduino-cli tagging convention, so this action will be able to pickup new v1.y.z versions. |
What
This PR updates the actions using Node 16 to Node 20
Why
GitHub is deprecating Node 16 for GitHub Actions. Therefore currently workflow runs using this action show the warning
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/setup-arduino-cli@v1.
This PR implements that change.More information is found on GitHub Actions: Transitioning from Node 16 to Node 20