Skip to content

Bump Node version to 20 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lenvm
Copy link
Contributor

@lenvm lenvm commented Feb 6, 2024

What

This PR updates the actions using Node 16 to Node 20

Why

GitHub is deprecating Node 16 for GitHub Actions. Therefore currently workflow runs using this action show the warning Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/setup-arduino-cli@v1. This PR implements that change.

More information is found on GitHub Actions: Transitioning from Node 16 to Node 20

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Feb 7, 2024
@LArkema
Copy link

LArkema commented Feb 18, 2024

+1 to prioritizing this PR

@stefan-b-jakobsson
Copy link

I hope this can be merged, as GitHub has announced that it will stop supporting Node16 "by Spring 2024".

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@LArkema
Copy link

LArkema commented Apr 3, 2024

@per1234 from what I can tell it looks like you're the main maintainer of this project. Any chance this can be merged?

@lenvm
Copy link
Contributor Author

lenvm commented Apr 26, 2024

@latchdevel, please sign the CLA such that this PR can be merged.

@latchdevel
Copy link
Contributor

Hi @per1234,

This pull request is ready for review and merging.

Best regards.
Jorge.

@latchdevel
Copy link
Contributor

Looking for PR reviewers: @MatteoPologruto, @LArkema, @stefan-b-jakobsson, @per1234...

Copy link
Contributor

@latchdevel latchdevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not entirely orthodox to review the changes myself, but there seems to be a lack of will, and the truth is that they are quite simple.

@latchdevel
Copy link
Contributor

Looking for PR reviewers: @umbynos , @alessio-perugini , @cmaglie ....

@alessio-perugini
Copy link
Contributor

@latchdevel thank you for the ping. Sorry for the late response, I will prepare a followup PR to address some changes made in arduino-cli tagging convention, so this action will be able to pickup new v1.y.z versions.

@alessio-perugini alessio-perugini merged commit 8dc9514 into arduino:master Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants