Skip to content

update to node16 (node12 support deprecated) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

henrygab
Copy link

See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Every user of this action is now getting warnings (not yet errors). For example:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: arduino/setup-arduino-cli

I have verified this small change removes this warning when I point to this PR branch. Given the simplicity of the fix, I hope that's sufficient.

See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Every user of this action is now getting warnings (not yet errors).

**_IMPORTANT_** - this change hasn't been tested.  this is because I'm not sure how I would do so.  given the trivial nature, it's likely the repo's built-in self-tests should give a pass/fail....
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrygab. The project infrastructure also must be updated to use Node.js 16.x in order to allow development and validation using the same version as will be used on the GitHub Actions runner:

  • Update package-lock.json file to the lockfileVersion 2 data format used by Node.js 16.x
  • Update the unit test workflow to run the tests using Node.js 16.x (it is currently using 10.x 👴)

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 21, 2022
@per1234 per1234 self-assigned this Oct 21, 2022
@henrygab
Copy link
Author

  • Update package-lock.json file to the lockfileVersion 2 data format used by Node.js 16.x
  • Update the unit test workflow to run the tests using Node.js 16.x (it is currently using 10.x 👴)

I updated the test runner to install Node 16.x instead of Node 10.x. I realize that validation is still necessary, and I am not familiar enough to attempt the lockfile changes. (while I love learning, time is a limiting factor.)

Thank you for self-assigning!

@astraw
Copy link

astraw commented Dec 16, 2022

I am getting this warning, too. @per1234 are there any remaining issues? AFAICS the changed requested have now been made. It would be great to make a release with to address the warning.

@per1234 per1234 linked an issue Jan 11, 2023 that may be closed by this pull request
3 tasks
@lhstrh
Copy link

lhstrh commented Feb 15, 2023

Is there anything left to do before this can get merged and released? It would be great to get rid of the warnings...

@ChanceCuddeback
Copy link

What is the status on this. I am a beginner at Github Actions so it may be my fault, but the action is now broken? Do I have to used a differenct verison of the action?

@joshua-8
Copy link

@ChanceCuddeback This action is still working for me here, though there are warnings that the action will stop working soon, so I hope it is fixed soon. Thank you Arduino Team for all your work.

@per1234 per1234 assigned per1234 and unassigned per1234 Oct 3, 2023
@per1234
Copy link
Contributor

per1234 commented Oct 3, 2023

Closing as superseded by #54

@per1234 per1234 closed this Oct 3, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current version generates Node 12 deprecation warning
7 participants