Correct example commands and output in README to reflect actual behavior of tool #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
|
I think we should wait on a decision on arduino/arduino-cli#1738 before merging this. It might be that the specification will be judged incorrect rather than the module behavior. The current readme is 50/50 on use of |
per1234
added
the
status: blocked
umbynos
suggested changes
May 18, 2022
…ior of tool The readme content seems to be based on the "dummy-monitor" tool rather than on serial-monitor, and also outdated. I have updated the commands and output to reflect the behavior of the tool from this repository.
per1234
removed
the
status: blocked
umbynos
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme content seems to be based on the "dummy-monitor" tool rather than on serial-monitor, and also outdated.
I have updated the commands and output to reflect the behavior of the tool from this repository.
The exception are some differences that are caused by bugs in the
github.com/arduino/pluggable-monitor-protocol-handlertool:valueskey names in DESCRIBE command response (Adjust pluggable monitor spec re:DESCRIBEcommand response to match library behavior arduino-cli#1738)QUITcommand response is not specification compliant pluggable-monitor-protocol-handler#13)The new readme content is written in expectation of specification compliance rather than reflecting the current buggy behavior.