Skip to content

Add infrastructure to check Markdown files for problems #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Add infrastructure to check Markdown files for problems #64

merged 3 commits into from
Dec 20, 2023

Conversation

per1234
Copy link
Collaborator

@per1234 per1234 commented Dec 20, 2023

These are standardized assets maintained at https://github.com/arduino/tooling-project-assets

Tasks and a GitHub Actions workflow are added for detecting problems in the project's Markdown files.

On every push and pull request that affects relevant files, and periodically, the workflow will check the repository's
Markdown files for problems:

- Use markdownlint to check for common problems and formatting.
- Use markdown-link-check to check for broken links.

The Arduino tooling Markdown style is defined by the `.markdownlint.yml` file.

In the event the repository contains externally maintained Markdown files, markdownlint can be configured to ignore them
via a `.markdownlintignore` file:
https://github.com/igorshubovych/markdownlint-cli#ignoring-files

markdown-link-check is configured via the `.markdown-link-check.json` file:
https://github.com/tcort/markdown-link-check#config-file-format
The project readme contains a table of contents in order to facilitate the navigation of the documentation.

It is important that this table of contents is kept in sync with the documentation content.

A task is added for automatically generating the ToC from the content of the file.

A GitHub Actions workflow is added to check the table of contents. On every push or pull request that affects relevant
files, it will check whether the table of contents matches the file structure.
These links result in invalid markup in the automatically generated table of contents.

They were not essential in any way and it is probably not a great idea to put links in headings anyway so they are
removed.
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Dec 20, 2023
@per1234 per1234 self-assigned this Dec 20, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe15060) 100.00% compared to head (b14b774) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          732       732           
=========================================
  Hits           732       732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@per1234 per1234 merged commit 2f24632 into arduino:main Dec 20, 2023
@per1234 per1234 deleted the markdown-infra branch January 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants