Skip to content

Skip expired workflow artifacts #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Skip expired workflow artifacts #10

merged 1 commit into from
Nov 16, 2020

Conversation

per1234
Copy link
Collaborator

@per1234 per1234 commented Nov 16, 2020

Workflow artifacts expire after a default of 90 days. For some reason, the GitHub workflow artifacts API
still lists these artifacts, even though they are no longer available. Previously, if the repository contained an open
PR with an expired artifact, it caused the action to fail when it tried to download the non-existent artifact and got an
HTTP 500 error.

Example:
https://github.com/arduino-libraries/ArduinoIoTCloud/runs/1403885124?check_suite_focus=true#step:3:31

Successful workflow run after this change:
https://github.com/arduino-libraries/ArduinoIoTCloud/runs/1404096185?check_suite_focus=true

Workflow artifacts expire after a default of 90 days. For some inscrutable reason, the GitHub workflow artifacts API
still lists these artifacts, even though they are no longer available. Previously, if the repository contained an open
PR with an expired artifact, it caused the action to fail when it tried to download the non-existent artifact and got an
HTTP 500 error.
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Nov 16, 2020
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @per1234 🚀

@aentinger aentinger merged commit 495ca5e into arduino:main Nov 16, 2020
@per1234 per1234 deleted the skip-expired-artifacts branch November 16, 2020 12:40
@per1234 per1234 self-assigned this Jun 13, 2024
@per1234 per1234 added the topic: code Related to content of the project itself label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants