Remove false implications about PROGMEM #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two false implications from PROGMEM.adoc: 1. That PROGMEM costs flash space (constants go to flash no matter what, PROGMEM only prevents them from being copied to ram at start up). 2. That reading PROGMEM data incurs the cost of an extra flash-to-SRAM copy (no extra copy: an SRAM-to-CPU copy is replaced by a flash-to-CPU copy). Also, add an empty line after `#include <avr/pgmspace.h>` for better formatting. Fixes arduino#739.
karlsoderby
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #739: PROGMEM.adoc falsely implies that
PROGMEMcosts flash space, and that readingPROGMEMdata incurs the cost of an extra flash-to-SRAM copy.Note that pull request #787 partially addressed the issue, but only fixed the section about the
F()macro.