keyboardModifiers: split modifiers and special keys #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language/Functions/USB/Keyboard/keyboardModifiers.adoc contains a table of key macros described as "modifier keys". Most entries in this table, however, are not modifiers: arrow keys, function keys, etc. Split the table in two: one table for the actual modifiers, and another one for all the other key macros, collectively described as "special keys".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in issue #871, the page Keyboard Modifiers incorrectly uses the term “modifier” for many keys that are not real modifiers, such as
KEY_UP_ARROW,KEY_BACKSPACE, etc. This pull request addresses the issue by splitting the table listing the “modifier keys” into two smaller tables:“Keyboard modifiers”, which now only lists the keys that are actually modifiers
“Special keys”, which lists all the other macros: keys that are neither printable characters nor modifiers.
Fixes #871.