Keyboard: incorrect use of the term “modifier”

[edgar-bonet]

In the documentation of the Keyboard library, the page Keyboard Modifiers provides a good definition of a “modifier key”:

A modifier key is a special key on a computer keyboard that modifies the normal action of another key when the two are pressed in combination.

The page then lists “the definitions of the modifier keys”, namely a set of macros such as KEY_LEFT_CTRL, KEY_RIGHT_SHIFT, etc.

Although the first entries in this list are indeed modifier keys, most of the entries are not: KEY_UP_ARROW, KEY_BACKSPACE, KEY_TAB, KEY_PAGE_UP, KEY_F1, etc. This is both wrong and inconsistent with the definition provided in the same page.