Make array size match array literal size #851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Currently, one of the sample lines of code in the
array
documentation declares an array of size 6, but assigns it a value of an array literal whose length is 5:This discrepancy has been confusing to me and my students, and may also result in undefined compiler behavior. (I'm not an expert on the Arduino-C compiler, but depending on how it resolves this statement it may result in an array of size 6 whose last element is garbage and/or whatever happened to be at that memory address.)
My suggestion
Make the declaration be for an array of size 5 (instead of size 6). This solution keeps much of the documentation the same, changing only the declared array size.