Skip to content

Add relevent links to other math functions [CNT-671] #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2022

Conversation

aliphys
Copy link
Contributor

@aliphys aliphys commented Jul 30, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2021

CLA assistant check
All committers have signed the CLA.

@aliphys aliphys changed the title Add relevent links to other math functions Add relevent links to other math functions [CNT-671] Jul 30, 2021
@aliphys
Copy link
Contributor Author

aliphys commented Jul 30, 2021

@per1234 could you review this?

@per1234
Copy link
Collaborator

per1234 commented Jul 30, 2021

It is somewhat a duplicate of #816

The problem is that we used to have a very nice system that generated these links automatically. That system was broken and I have never been able to get a straight answer on whether it can simply be fixed rather than requiring us to manually replace and maintain a huge number of links just to get back to what we had for years.

@aliphys
Copy link
Contributor Author

aliphys commented Mar 22, 2022

@per1234 If this PR is obsolete, could you close it? Thanks!

@per1234
Copy link
Collaborator

per1234 commented Mar 22, 2022

@aliphys since I still have not been able to get a straight answer after two years of trying, I think we must conclude that the automated links system will never be repaired and that it will be necessary to manually replace and maintain the links.

So this PR is not obsolete.

@aliphys aliphys requested a review from per1234 August 15, 2022 07:36
@aliphys aliphys requested a review from per1234 September 5, 2022 07:39
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aliphys!

@per1234 per1234 merged commit e06c404 into arduino:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants