Skip to content

Change ''D" to "d" in <gives you the String "D"> #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021
Merged

Change ''D" to "d" in <gives you the String "D"> #831

merged 1 commit into from
May 25, 2021

Conversation

brewmanz
Copy link
Contributor

Perhaps the code has changed over time, but this documentation change is for the reference to reflect reality.
Also consider changing the code to perhaps accept HEX_UPPER & HEX_LOWER.

Perhaps the code has changed over time, but this documentation change is for the reference to reflect reality. 
Also consider changing the code to perhaps accept HEX_UPPER & HEX_LOWER.
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brewmanz!

It's unfortunate that Arduino's String and Print classes are not consistent in this regard:

Serial.println(String(13, HEX));  // d
char buf[2];
itoa(13, buf, 16);
Serial.println(buf);  // d
Serial.println(13, HEX);  // D

@per1234 per1234 merged commit efc1249 into arduino:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants