Skip to content

[Documentation] Missing data type #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Conversation

mohammedhemed77
Copy link
Contributor

@mohammedhemed77 mohammedhemed77 commented Feb 20, 2021

In the documentation of Floating Point I noticed this example:

n = 0.005;  // 0.005 is a floating point constant

This code simply won't compile and get this error :
'n' does not name a type

so this Line should be :

const float n = 0.005;  // 0.005 is a floating point constant

Although this error may seem trivial for some professionals , but I think it seems misleading to newcomers.

In the documentation of Floating Point is this example:

```
n = 0.005;  // 0.005 is a floating point constant
```
This code simply won't compile and get this error :   
'n' does not name a type

so this Line should be : 

```
const float n = 0.005;  // 0.005 is a floating point constant
```
Although this error may seem trivial for some professional , but I think it seems misleading to newcomers.
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@mohammedhemed77
Copy link
Contributor Author

What happened if I close this pull request after all commiters have signed CLA ?
It will be merged ? @per1234

@per1234
Copy link
Collaborator

per1234 commented Apr 24, 2021

@mohammedhemed77 if you close the pull request it won't ever be merged.

@per1234 per1234 dismissed their stale review May 8, 2022 01:08

Requested change has been made.

Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per1234 per1234 merged commit f0431be into arduino:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants