-
-
Notifications
You must be signed in to change notification settings - Fork 731
Include Nano 33 and Portenta #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f09a9e8
Include Nano 33 and Portenta
ubidefeo faf193d
Update Language/Functions/Zero, Due, MKR Family/analogReadResolution.…
ubidefeo 563a8a2
Update Language/Functions/Zero, Due, MKR Family/analogReadResolution.…
ubidefeo b81910a
changed subcategory to "Analog I/O"
ubidefeo 1364733
Sub-category changed back to "Zero, Due & MKR Family"
ubidefeo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would cause the page to no longer be published at https://www.arduino.cc/reference/en/:
The reason is because no subcategory of this name has been defined. One could be defined, but I think it's not a sustainable strategy to continuously append board names as needed.
Better would be to change to a non-board specific category name. I would prefer to just move the
analogReadResolution()
andanalogWriteResolution()
reference pages to the "Analog I/O" subcategory, then make sure the reference pages are very clear about which boards support these functions.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes a lot of sense, Per
I don't know how such content is organised, and I'm glad you posted your feedback 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the category change and will post it as another PR