Skip to content

Updated Float #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed

Conversation

animeshsrivastava24
Copy link
Contributor

@animeshsrivastava24 animeshsrivastava24 commented May 30, 2019

Added the representation of Float number with 'e' representation (for making more user friendly ).
Created Notes and Warning Section as suggested and shifted the information to make it easy to understand.
Added the Truncation and round off methods to notes and warnings.
Limited the Code Example Section to only One.
In reference to issue #579

Added the representation of Float number with 'e' representation (for making more user friendly ).
Created Notes and Warning Section as suggested and shifted the information to make it easy to understand.
Added the Truncation and round off methods to notes and warnings.
Limited the Code Example Section to only One.
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes I requested in #606 by making a commit to the patch-2 branch of your fork. That commit will automatically update #606.

You can make this PR be exclusively for your proposal to add the explanation of E-notation to the Float documentation.

As to that proposal, I feel that the sentence you are trying to add makes the documentation goes off on a tangent and makes it unnecessarily complicated. I would prefer just adding a link to an external page that explains E-notation for those who don't already know what it is. Something like this:

Floating-point numbers can be as large as 3.4028235E+38 and as low as -3.4028235E+38 (E-notation).

Unfortunately, it seems there may be an undocumented rule against external links (#467 (comment)). We're currently waiting on some clarification on that rule (#576 (comment)).

@per1234
Copy link
Collaborator

per1234 commented Jun 1, 2019

Since in 6d7b46a you removed the only thing in this PR that gave it a different purpose from #606, and there is better discussion in #606, I'll now close this PR as a duplicate.

@per1234 per1234 closed this Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants