Skip to content

Updated details of Arduino MKR1000 #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 2, 2019

Conversation

animeshsrivastava24
Copy link
Contributor

Added the details of PWM Pin and Frequency of operation. In response to Issue #587

Added the details of PWM Pin and Frequency of operation. In response to Issue arduino#587
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @animeshsrivastava24 I am going to request some changes:

Format as a table

We eventually need to document all the entire, ever-increasing list of Arduino boards here. In paragraph form, that will quickly become an impenetrable wall of text. The solution is to format this information as a table with the following columns:

  • Board
  • PWM pins
  • PWM frequency

You can see an example of such a table here:
https://github.com/arduino/reference-en/blob/master/Language/Functions/Communication/Serial.adoc

The added PWM documentation applies to all MKR boards

The PWM pins are the same for all MKR boards so just call them MKR boards in that row of the table. No need to have a special row for each individual MKR board.

@per1234 per1234 mentioned this pull request May 31, 2019
animeshsrivastava24 and others added 14 commits June 1, 2019 18:37
@animeshsrivastava24
Copy link
Contributor Author

@per1234 Pardon me for inefficiency in Pull Requests, it's lately been since I tried using the Git Version directly from Websites rather than using the command line, I'll divert back to the command line tool. I tried resolving above suggestions.

@per1234 per1234 merged commit c471d9f into arduino:master Jun 2, 2019
@per1234
Copy link
Collaborator

per1234 commented Jun 2, 2019

@animeshsrivastava24 I prefer to use a Git client software on my computer combined with Git commands from the command line for the things that the Git client doesn't do, or doesn't do well. However, the more limited GitHub web interface should work well enough for contributions to this project if people prefer that. Certainly the GitHub web interface is the easiest to use for people without prior experience with Git.

@animeshsrivastava24
Copy link
Contributor Author

@per1234 Thank you so much for the guidance. Also, I am eagerly waiting for your e-mail replies so that I can summarize and progress more for the Documentation and GSoD'19 Work, please guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants